search

wynick27 / steam-missing-covers-downloader

Adds missing library covers for new steam UI
Other
73 stars 13 forks source link

async issues perhaps when it needs to download too many images? #18

Closed Jonius7 closed 1 year ago

Jonius7 commented 4 years ago

I was doing some tests with the downloader and for some reason it sometimes fails. My full library without any images requires 301 images to be downloaded and these errors pop up:

https://pastebin.com/xbnZakvV

It fails to download any images to the grid folder. However if I copy most of my images in and have it download 100 images, or a couple of images, it successfully downloads them, but still has Event loop is closed errors

barryjj commented 3 years ago

I found a reference to why the Event loop is closed errors are showing up.

https://github.com/encode/httpx/issues/914#issuecomment-622586610

Using the workaround code from there in missing_cover_downloader.py fixed the issue with asyncio and event loops.

Jonius7 commented 1 year ago

Fixed in 407e820ec43b61d1f4329a4703a92010b6707ff2