The current implementation forces a renewal every 30 minutes. The values should be retrieved via protected getters so that every realm can subclass the current AutoLogin on overwrite these getters in order to implement another renewal period
The current implementation does not support multiple valid cookies for the same domain.
The current implementation uses a static final SimpleDateFormat object. According to the javadoc, that implementation is not thread-safe so it should be newly generated for each request.
What do you think about the following improvements that should be made in the AutoLogin.java?
Source: https://github.com/wyona/yanel/blob/master/src/webapp/src/java/org/wyona/yanel/servlet/security/impl/AutoLogin.java
Improvements:
protectedgetters so that every realm can subclass the current AutoLogin on overwrite these getters in order to implement another renewal periodSimpleDateFormatobject. According to the javadoc, that implementation is not thread-safe so it should be newly generated for each request.What do you think?