search

wyona / yanel

http://www.yanel.org
Apache License 2.0
10 stars 5 forks source link

Cleanup duplicated libraries #8

Closed michaelwechner closed 12 years ago

michaelwechner commented 12 years ago

Hi Michael, I suspect that my "git fetch" in the local yanel repo did not work as expected. I deleted now my local git repo of yanel and fetched it again from github. Now it looks much better, but still I see the following duplicates (or non-matching version numbers between API and Impl): So these libs are backport-util-concurrent-2.2.jar backport-util-concurrent-3.1.jar

same for me

commons-beanutils-1.6.jar commons-beanutils-1.7.0.jar

same for me

commons-collections-2.1.jar commons-collections-3.2.jar

I have got one more even:

commons-collections-2.1.jar commons-collections-3.1.jar commons-collections-3.2.jar

commons-logging-1.0.4.jar but the API is version 1.1 (maybe this has to be like this, I don't know, I'm just mentioning it): commons-logging-api-1.1.jar

same for me

commons-logging-1.0.4.jar commons-logging-1.1.jar

dom4j-1.5.2.jar dom4j-1.6.1.jar

same for me

All others have been cleaned up. Sorry for the first list, but I guess you should have a look at these libs here. I looked at different locations for this analysis:

  • First I deleted the local maven repository and built yanel from scratch. In the Maven repo you see more duplicates but that can be (e.g. older contribution resources or whatever might have an old dependency). But as long as these resources are not used, it won't harm.
  • Secondly after a clean build followed by the regular build of Yanel, I checked the libs in YANEL/build/webapps/ROOT/WEB-INF/lib : from here I put together the list above. Let me know what you think,

I agree we should clean this up or at least add them to the list of duplicates at

src/build/build.properties (property duplicated.libs)

michaelwechner commented 12 years ago

I have added two of these libraries to:

git diff src/build/build.properties diff --git a/src/build/build.properties b/src/build/build.properties index 76067ed..2b953a7 100644 --- a/src/build/build.properties +++ b/src/build/build.properties @@ -91,6 +91,9 @@ duplicated.libs=commons-lang-2.1.jar,\ commons-lang-2.2.jar,\ commons-lang-2.3.jar,\ commons-lang-2.4.jar,\

but will check more closely later on

baszero commented 12 years ago

beanutils and collections added to duplicate property: see 1b41fcb0ac3e9ec6265a971aafb09b47a0d9f6f1