search

wyrm65 / skin.apptv

Kodi Media Center Skin AppTV
Other
17 stars 13 forks source link

Games Settings and Event Log #25

Closed mapi68 closed 1 year ago

mapi68 commented 1 year ago

According to https://github.com/wyrm65/skin.apptv/issues/24

wyrm65 commented 1 year ago

mapi68,

issues fixed in my pull https://github.com/wyrm65/skin.apptv/commit/115a13d32b8617e74b2ed0c3749f5bf4387fed97 .

Thank you on the system level string id for Event log, for some reason the exact string in my strings file was obviously mistranslatted.

On the Games setting string and others I am now using the exact same strings as Estuary (which probably makes sense as user already knows they are changing settings, so no need to call it blah setting).

Games is correct as there has been a games setting item in Kodi for a number of versions now. The developer responsible for adding Gaming to Kodi did not add the string in the correct number range and thus the reason why you might think is not required.

Closing this pull as no longer required, but thanks for the heads up on the issue

Wyrm