wysiib / linter-languagetool

Integration of Languagetool into the Atom text editor.
MIT License
17 stars 5 forks source link

Make languagetools only accessible on local loopback #11

Closed robertmd closed 7 years ago

robertmd commented 7 years ago

Currently, the languagetools server is running in public mode. This is not needed as it only is access via the local loopback. This will prevent other people on the network using languagetools and reduce the risk of someone exploiting the open port.

Below is the code that includes the public parameter located here:

ltserver = child_process.exec 'java -cp ' + ltjar + ' org.languagetool.server.HTTPServer --public "$@"', (error, stdout, stderr) ->

wysiib commented 7 years ago

Thanks for the report!

I remember there have been some problems with the Mac OS(?) firewall if the --public flag is not set. Will look into it again in the coming days.

robertmd commented 7 years ago

No problem. By the way I made the modification on windows to only run on local loopback and it worked fine for me. That being said I don't have a Mac to test the changes on.

wysiib commented 7 years ago

With the current version of languagetool it is working fine on Mac as well. Did you just remove the "--public"? Or where further changes necessary to make things run on windows?