Server start/stop on package activate/deactivate

wysiib / linter-languagetool

Integration of Languagetool into the Atom text editor.

MIT License

17 stars 5 forks source link

Server start/stop on package activate/deactivate #20

Closed davidlday closed 6 years ago

davidlday commented 6 years ago

Closes #19 - I added activate / deactivate to linter-language (per Standard Linter v2 spec). On activate a new LinterProvider is constructed, and the server is started within the constructor. On deactivate, provider.destroy() is called, which cleans up the running process.

I also added a config option for the port, defaults to the default for LanguageTool. I have two machines where port 8081 is already in use and figured I might not be the only one with this conflict.

davidlday commented 6 years ago

I'm closing this pull request because I happened to notice on the original issue @hesstobi has a more elegant solution on his fork that includes restarting on configuration changes.