search

wysiib / linter-languagetool

Integration of Languagetool into the Atom text editor.
MIT License
17 stars 5 forks source link

JVM Memory Options / JAVA_OPTS #30

Closed davidlday closed 6 years ago

davidlday commented 6 years ago

I'd like to either add two configuration items to control JVM memory consumption - -Xms and -Xms - set to reasonable defaults (like 256m and 512m) or possibly add a single configuration item with free-form jvm options like the JAVA_OPTS environment variable to give more control over how the language tool service runs.

Thoughts?

wysiib commented 6 years ago

Given that these options will probably only be used by experienced users, I think the free-form one would be sufficient. On the other hand, making the memory options easily available could help inexperienced users as well. However, as soon as we introduce those two options seperately, somebody will be asking for a third and fourth option for sure. All in all, I'm leaning towards the free-form option for JVM options. Introducing it is not much work. Do you want to send a pull request? If not, I can implement it in the next few days.

davidlday commented 6 years ago

@wysiib - I'll see if I can put something together today. Thanks!

wysiib commented 6 years ago

You need any help?

davidlday commented 6 years ago

Yes, please. My apologies for letting this get away from me. I've had trouble making the time to tackle this. If you have time to implement, by all means don't wait on me.

And if you could somehow add a few extra hours to every day, that would be cool, too. 😆