wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
162 stars 21 forks source link

Custom model for Dulcimer and Tinkle Bell #106

Closed TheCococQuartz closed 20 hours ago

TheCococQuartz commented 2 years ago

The prob Some instruments in MidiJam where given incorrect visualizations, likely because it was a placeholder model, there are 2 that I feel like should be updated:

s11141827 commented 1 year ago

So my idea was to have the Dulcimer indicated as a Hammered Dulcimer w/ a Chromatic Piano layout.

TheCococQuartz commented 6 months ago

lol I completely forgot about opening this issue.

To respond to your comment from over a year ago; yeah, the hammered dulcimer would be a better fit, turns out the mountain dulcimer is basically just a type of ukulele. I didn't know that at the time and decided to suggested the one that would be easier to model.

But personally I don't think the piano layout is a great fit for the dulcimer. My idea was to do what was done with the harp, take the original diatonic design and just add more strings for the chromatic notes.

s11141827 commented 2 months ago

lol I completely forgot about opening this issue.

To respond to your comment from over a year ago; yeah, the hammered dulcimer would be a better fit, turns out the mountain dulcimer is basically just a type of ukulele. I didn't know that at the time and decided to suggested the one that would be easier to model.

But personally I don't think the piano layout is a great fit for the dulcimer. My idea was to do what was done with the harp, take the original diatonic design and just add more strings for the chromatic notes.

I would prefer the Piano Keyboard Layout Hammered Dulcimer because that would be killer.

wyskoj commented 20 hours ago

Merging into #208.