wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
165 stars 21 forks source link

Small Problem Capturing midis2jam2 with OBS since version 1.5 #130

Closed VGMRUS closed 2 years ago

VGMRUS commented 2 years ago

Describe the bug A clear and concise description of what the bug is. There's a small (but annoying) problem with capturing midis2jam2 visualizer windows starting the 1.5 version, I don't know what could have caused this but,

Since the version 1.5 OBS will keep capturing the visualizer window even when it's closed and if you try to open/play another midi it won't capture the new visualizer window at all and keep capturing the first already closed frozen window, it's really annoying and to fix this you have to either mess with which window OBS is capturing or close midis2jam2 completely

when you close the launcher the closed visualizer window that is still being captured (even though it's closed) stops being captured by OBS

In the version 1.4 when the visualizer windows closes OBS also stops capturing said window immediately which was really good behaviour

It's like since 1.5 the visualizer window didn't close completely and OBS was detecting that making this issue, so if there's any remain of this window when getting closed getting rid of it should probably fix it

Expected behavior A clear and concise description of what you expected to happen. When the visualizer window gets closed OBS should detect that the captured window is gone and stop the capture (like in version 1.4)

Screenshots If applicable, add screenshots to help explain your problem. OBS basically keeps the last frame shown on the visualizer window as if it were a image instead of stoping capture as it should (as it does in version 1.4) imagen

wyskoj commented 2 years ago

Enable the legacy display engine.

In v1.7, the legacy display engine will become the default (4843e27232a8ac358351f83bd61ba33db0580136), so this issue will be fixed.

VGMRUS commented 2 years ago

Legacy display being enabled does fix it, thanks