search

wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
162 stars 21 forks source link

Choir notes are reversed #16

Closed cunningar0807 closed 6 months ago

cunningar0807 commented 3 years ago

I was trying out the onestop.mid file using the Midis2jam2 Jar file on my Mac OS Big Sur. I noticed that the Choir Visuals have swapped chromatic notes. When I mean swapped, I meant that the notes are in the order of (Ab/G# G Gb/F# F E Eb/D# D Db/C# C B Bb/A# and A), just like the original visualized Brass section from the Original MidiJam program.

The correct chromatic notes in order for the choir visuals should be (A A#/Bb B C C#/Db D D#/Eb E F F#/Gb G and G#/Ab).

I'm sure that this will be a simple and easy bug to fix.

wyskoj commented 6 months ago

I've made a bunch of changes to these instruments since then. Wouldn't be a bad idea to revisit them and make sure they are still compliant.

wyskoj commented 6 months ago

Resolved by 4535af5b180439d29ef0b80789f285832eb6b8b4.