search

wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
165 stars 21 forks source link

Reverb toggle doesn't work. #204

Closed RukoBlood closed 1 month ago

RukoBlood commented 1 month ago

Describe the bug On gervill synthesiser reverb toggle makes no sense. Even when turned off, reverb still exists

Offending MIDI file Every midi file.

Expected behavior No reverb when reverb turned off.

Screenshots image No Reverberation. But still gervill reverb.

System Windows 10 Pro 22H2 i5-3230M, GT 720M, 8GB DDR3

Additional context No additional context.

wyskoj commented 1 month ago

These settings work by sending a control change message to the synthesizer to disable the effects. If a MIDI file also has control change messages sent, they will trump mine and the reverb will be turned back on. So there's not a practical way for me to absolutely guarantee that the effects will be disabled. (The Java Sound API does not expose a nice function like setReverbEnabled so the best I can do is send a MIDI message to disable it.)

If disabling reverb is critical to your use case, I suggest installing an external synthesizer like VirtualMIDISynth which has better configuration options available. The primary function of midis2jam2 is not audio synthesis but rather animation.

RukoBlood commented 1 month ago

Thanks.