search

wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
165 stars 21 forks source link

JME resources are not being cleaned up after process is done, JVM memory eventually overflows #80

Open TheCococQuartz opened 2 years ago

TheCococQuartz commented 2 years ago

Describe the bug After playing many MIDI files the program stops being able to play anything because it's "out of memory" This is because Midis2Jam2 slowly starts taking up more memory as you play MIDI files till it runs out of memory, the only way to fix this is to close and reopen the program. Bruh

When Midis2jam2 was booted up, this is how much memory it took up: OnStartup

After playing a MIDI file (Regardless of size), now it takes up this much:
ThisIsWhatNicotineDoesToYourLungs

And it doesn't stop, it just keeps going up till the program can't handle it or something and you get that error message OversightMuch(QuestionMark) (It took up this much memory when I got that error message)

System This is on Windows 10 btw

wyskoj commented 2 years ago

@TheCococQuartz how many MIDI files did you play until it ran out of memory?

TheCococQuartz commented 2 years ago

@wyskoj 20 And if this is useful, I also noticed that the MB it uses goes up by ~200 after the first 3 files then only by ~100 for the rest. The last attempt barely changed the MB usage at all then I got the error message the next attempt.

TheCococQuartz commented 2 years ago

@wyskoj 20 And if this is useful, I also noticed that the MB it uses goes up by ~200 after the first 3 files then only by ~100 for the rest. The last attempt barely changed the MB usage at all then I got the error message the next attempt.

wyskoj commented 2 years ago

I can't seem to replicate the bug, so I'm not sure what the solution is to fix this. However, I just added something that might remedy this. When the next release comes out, give it a try and see if you have the same issue. If so we'll go from there.

TheCococQuartz commented 2 years ago

alright 👌

TheCococQuartz commented 2 years ago

@wyskoj Just download RC2, it still has the same issue :(

wyskoj commented 2 years ago

Okay, I'll look into this further for the next release.

wyskoj commented 1 year ago

@TheCococQuartz Are you able to replicate this issue in v1.8.0?

TheCococQuartz commented 1 year ago

The memory still increases but at a much slower rate. I played 21 MIDIs and it only went up to 747MB, which means it’ll take ~110 MIDIs or so to reach 3000MB and the ‘out of memory’ error (assuming it keeps increase linearly). I see that as a fix!