search

wyskoj / midis2jam2

🎶 A remaster of MIDIJam, a 3D MIDI file visualizer.
https://midis2jam2.xyz
GNU General Public License v3.0
165 stars 21 forks source link

Skybox texture doesn't load properly #85

Closed TheCococQuartz closed 2 years ago

TheCococQuartz commented 2 years ago

Describe the bug For some reason, some new textures added in 1.5 don't show up. For example, the skybox, it's just the original black void it was before. AAAAAAA This also includes every new drum texture (excluding power), which just displays the default blue texture. The midi playing above (this one) uses a drumkit other than the default and power one (idk the names, whichever one uses patch 25) and as you can see, still blue.

These textures are in the files, but for some reason don't show up. Even weirder, when I edited the sky texture, the text I added to it showed up but the actual sky texture still doesn't. sans WHAT I tried this on the new drum textures but nothing happened

Maybe the retexturing function doesn't work or something, just a guess.

System Windows 10

Additional comment last bug report i swear

wyskoj commented 2 years ago

That drum kit (TR-808 Kit) doesn't have a special texture, it just uses the regular blue kit. However that skybox bug is very strange and I'm not sure what's causing that. What if you try making the skybox picture some other picture? Just to test and see if something like a normal photo or something appears correctly.

TheCococQuartz commented 2 years ago

I changed it to some forest picture and it was all black, no trace of anything. notnice

Not only that but I decided to take the edited texture I originally posted and paste it onto a different file. When I reopened that file the tiles where gone. It seems that the lighter tiles where replaced with the color of the darker tiles glowup (picture was downscaled to be readable btw)

(side note, I had no idea there where 8 drumkits, I only knew 4 of them and though the 4 added where the ones I knew, whoops)

wyskoj commented 2 years ago

That is extremely strange and sounds like an upstream issue—i.e., not the result of my code. Although I will keep this bug on the table, not much I can do for now.

wyskoj commented 2 years ago

Upon further research, JME only allows square images for skybox images. So that's why the image didn't appear. #103 will add a user-friendly implementation of customizing backgrounds so this shouldn't be an issue anymore.