search

wyuenho / all-the-icons-dired

Adds dired support to all-the-icons
GNU General Public License v3.0
23 stars 7 forks source link

Display incorrect icons after press "l" #14

Closed seagle0128 closed 2 years ago

seagle0128 commented 2 years ago

I think the root cause is the advice of dired-do-redisplay is missing. Please take a look at this issue. Thanks!

https://github.com/wyuenho/all-the-icons-dired/blob/5e9b097f9950cc9f86de922b07903a4e5fefc733/all-the-icons-dired.el#L113-L136

wyuenho commented 2 years ago

Please submit a screenshot of the problem and what is expected. If you have any stacktraces, please send over them as well.

seagle0128 commented 2 years ago

No any stacktraces or errors since it's not a bug.

The screenshot is below. The icon was displayed incorrectly after pressing l (dired-do-redisplay) in dired buffers.

The workaround is 

(with-eval-after-load 'dired-aux
        (advice-add #'dired-do-redisplay :around #'all-the-icons-dired--refresh-advice))
image
wyuenho commented 2 years ago

See if master works for you