Closed tusharhero closed 3 months ago
Emacs 30 has not been released yet.
The fix by yantar92 seems to be simple enough?
Jimmy Yuen Ho Wong @.***> writes:
Emacs 30 has not been released yet.
Yes, but the code is still just working by chance; because of undocumented behavior of `pcase-let'.
`(, ,action ,file ,@) pcase pattern is simply invalid.
Let me illustrate using Emacs 28:
(pcase '(foo bar baz test) (`(, ,action ,file ,@) (list action file))) ; => nil
As you can see, the pattern you use does not match what you expect.
The correct pattern would be:
(pcase '(foo bar baz test) (`(, ,action ,file . ,) (list action file))) ; (bar baz)
-- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92
@tusharhero ^ that doesn't look like your PR
Oh yeah, I just did what they had told me would fix it in group chat. I have been using the fork myself and it seems to work. But I will try this fix as well to see if it works.
Description Error when installing using
use-package
to install.Reproduction steps