Fix incorrect pcase pattern.

[tusharhero]

Fix for #34

[wyuenho]

Do you mind adding a test case for this bug please?

[tusharhero]

@yantar92 Can you please clarify if this is the right one? Because in you intially asked me to the diff as in this PR, but in the Github issue you did something else.

What we are currently doing:

-    (pcase-let ((`(,_ ,action ,file ,@_) event))
+    (pcase-let ((`(,_ ,action ,file) event))

What you suggested in your comment:

-    (pcase-let ((`(,_ ,action ,file ,@_) event))
+    (pcase-let ((`(,_ ,action ,file,_) event))

Both of them seem to work in my configuration.

[yantar92]

tusharhero @.***> writes:

@yantar92 Can you please clarify if this is the right one? Because in you intially asked me to the diff as in this PR, but in the Github issue. You did this.

What we are currently doing:

-    (pcase-let ((`(,_ ,action ,file ,@_) event))
+    (pcase-let ((`(,_ ,action ,file) event))

This will work, because of undocumented (yet! see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68509#20) behaviour of destructuring pcase-let.

What you suggested in your comment:

-    (pcase-let ((`(,_ ,action ,file ,@_) event))
+    (pcase-let ((`(,_ ,action ,file,_) event))

• • (pcase-let ((`(, ,action ,file . ,) event)) (dot is important)

This variant will also work. It provides a correct pattern in a pcase' sense, without making use of specific behavior ofpcase-let'.

I'd personally use the second variant, but you or @wyuenho can use either.

-- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92

[tusharhero]

Hey @wyuenho , I fixed it to be the one suggested by yantar. I have no idea how to make a test case, can you please provide any pointers?