search

wyveo / nginx-php-fpm

Nginx + PHP-FPM 8.2.x / 8.1.x / 8.0.x / 7.4.x / 7.3.x / 7.2.x / 7.1.x / 7.0.x + Composer built on Debian (Bullseye/Buster) image
https://hub.docker.com/r/wyveo/nginx-php-fpm
MIT License
342 stars 245 forks source link

Composer upgrade on PHP 7.x images #44

Closed gdevdeiv closed 2 years ago

gdevdeiv commented 2 years ago

Hi there,

I would like to ask if there is any particular reason for which Composer is locked to version 1 on PHP 7.x images. I am going to fork the repository to upgrade those for personal use, would like to know as I can PR easily.

Thanks, David.

colinwilson commented 2 years ago

@gdevdeiv No. No particular reason actually. AFAIK it's 100% backwards compatible with version 1. PRs more than welcome. Thank you.

maxdmyers commented 2 years ago

@colinwilson I've opened #47, #48, #49, #50 and #51 to bring composer up to v2 for all php 7.x branches.

colinwilson commented 2 years ago

@maxdmyers Awesome. Thank you so much for contributing. Will merge these shortly.

maxdmyers commented 2 years ago

@colinwilson Thank you!

maxdmyers commented 2 years ago

@colinwilson Do you have an idea when you might able to merge these? I'm working on testing some things and want to make sure I update to use the correct base image again when you're finished.

colinwilson commented 2 years ago

@maxdmyers merged now. Thanks again for these PR's. Much appreciated 👍