Ensure authenticated proxy can be transferred

wyvernprotocol / wyvern-v3

Wyvern Protocol v3.1, Ethereum implementation

https://wyvernprotocol.com

MIT License

298 stars 121 forks source link

Ensure authenticated proxy can be transferred #15

Closed cwgoes closed 5 years ago

cwgoes commented 5 years ago

Bought/sold through Wyvern order
Orders signed / settled afterwards

cwgoes commented 5 years ago

Note that for this to be safe, the user really has to assert ownership of the asset(s) they care about (otherwise the prior owner could front-run the order match transaction).

cwgoes commented 5 years ago

This works, but note that presently a user can only have one Wyvern proxy, and a user purchasing a proxy account cannot already have a proxy.

I think that could safely be changed by having:

Proxy address a signed-over field in each order
Exchange check the proxy user account instead of checking the registry mapping
Registry store a mapping of contracts to booleans (ensuring correct instantiation)

That would not be backwards-compatible with the v2 registry.

cwgoes commented 5 years ago

That would not be backwards-compatible with the v2 registry.

However, the v3 registry could reference the v2 registry and add an "upgrade" function to transfer the mapping - after which (along with disabling of the v2 Wyvern contracts) it would be safe to sell a v2 proxy contract.