Consider splitting concerns of static calls - Githubissues

wyvernprotocol / wyvern-v3

Wyvern Protocol v3.1, Ethereum implementation

https://wyvernprotocol.com

MIT License

298 stars 121 forks source link

Consider splitting concerns of static calls #26

Open cwgoes opened 4 years ago

cwgoes commented 4 years ago

General concern about calls happening before static checks.

Authenticate call data
Return fill
Check state changes
Call gets signed? Maybe an option.

Other points

If maker == sender, do we need a static call at all? Then we could avoid anyXYZ contracts.
Orders could optionally sign some hash of calldata
Maybe an application-operator-specific whitelist (application operator could change)