search

wyyerd / stripe-rs

Rust API bindings for the Stripe HTTP API.
Apache License 2.0
224 stars 88 forks source link

Update non-exhaustive method lists #126

Closed ThouCheese closed 4 years ago

ThouCheese commented 4 years ago

Some payment method enums exported by stripe-rs are non exhaustive in their current state. This pull request adds the missing variants to the enums that were not exhaustive. The PaymentMethodType enum contains a variant called CardPresent, but according to the documentation provided by stripe, this is not a valid variant. I have removed this variant. I have also added documentation to show what each of the variants mean with a link to stripes documentation.

ThouCheese commented 4 years ago

Note that adding and removing variants to an enum is sadly a breaking change.