search

wyyerd / stripe-rs

Rust API bindings for the Stripe HTTP API.
Apache License 2.0
219 stars 88 forks source link

Please allow others to manage this repo if you do not have time to properly review PRs and Issues! #168

Open seenickcode opened 3 years ago

seenickcode commented 3 years ago

@wyyerd it may be a good idea to give certain contributors write access to this repo so we can ensure it's maintained promptly. CC @seanpianka

seanpianka commented 3 years ago

cc: @kestred @stearnsc

arlyon commented 3 years ago

I have been maintaining a fork at https://github.com/arlyon/async-stripe for a while now, it's diverged a little as I've been adding other things but I have the time to stay on top of issues (and very open to PRs!)

The most notable feature is pluggable runtimes so you can use it on tokio and async-std, here is a more comprehensive list: https://github.com/arlyon/async-stripe/issues/42

stearnsc commented 3 years ago

Hi! I'm sorry, this repo had flown somewhat under my radar (I inherited it via reorganization at work). I'm absolutely in favor of adding more maintainers. I believe @kestred is still the only one who can publish versions, but that can probably change as well. @seanpianka are you interested in this? @arlyon is upstreaming your fork something you're interested in doing?

I don't have a lot of context into whether there are particular concerns I should be considering in adding maintainers re planned direction of the repository, but my instinct is to just add one or both of you as maintainers, if you're interested. @kestred do you have any thoughts or concerns?

arlyon commented 3 years ago

Happy to upstream any changes. There are about 70 commits at this point, so there's a lot that I have changed but the link above has a short summary which I believe is for the better so it's really down to how much you are willing to take on. It's foss for a reason! :)

Some of the more opinionated changes are moving to github actions, reworking the feature flags, changing the tests (mainly to utilise github actions better), changing the error code, using cargo make, and adding sorting and grouping to rustfmt. Obviously if any one of those is a dealbreaker it makes the code harder to upstream but as time went on keeping compatibility with the original fork was less and less of a priority. Let me know what you think.

kestred commented 3 years ago

@stearnsc, can you choose a committer you trust to maintain this and I can transfer the Cargo authorization to you to assign as needed?

seanpianka commented 3 years ago

Perhaps both of us, I'm up for helping get important fixes merged and start to upstream @arlyon's changes.

arlyon commented 3 years ago

Happy to help with the upstreaming on this side as well. It would reduce the bottleneck significantly having multiple people but not critical.

stearnsc commented 3 years ago

Alright, @seanpianka and @arlyon have both been added as maintainers. @kestred can you add me as an owner via cargo?

mikeumus commented 3 years ago

@kestred @stearnsc @arlyon @seanpianka may we consider turning on GitHub Discussions to get a little more organized and GitHub Sponsors to help water the repo a little? water 💦 🌱 🌞