search

wyyerd / stripe-rs

Rust API bindings for the Stripe HTTP API.
Apache License 2.0
219 stars 88 forks source link

several bug fixes to client #192

Closed daringordon closed 2 years ago

daringordon commented 2 years ago

see: https://stripe.com/docs/api/charges/object#charge_object-payment_method_details-card-brand

daringordon commented 2 years ago

1) detach payment method 2) create setupintent enhancement 3) payment_intent update enhancement 4) aligned the expected serde values for CardBrand with those received from the stripe api 5) add transfer_data to payment_intent update

stearnsc commented 2 years ago

I think this looks good other than the CardBrand issue - if https://github.com/wyyerd/stripe-rs/pull/188 meets your needs for that portion, I'm happy merging the other parts.

seanpianka commented 2 years ago

Thanks for the review, @stearnsc!

@daringordon, would you be interested in submitting separate PRs for these different changes? I believe the first change has now been covered by #141.

daringordon commented 2 years ago

OK. I'm closing this PR as two of the commits in it were addressed by 188 and 141. This PR is now replaced by a reduced version: https://github.com/wyyerd/stripe-rs/pull/202

@seanpianka @stearnsc