search

wyyerd / stripe-rs

Rust API bindings for the Stripe HTTP API.
Apache License 2.0
223 stars 88 forks source link

New contributors #196

Closed imalsogreg closed 2 years ago

imalsogreg commented 2 years ago

Hello! We have been using stripe-rs at work. We really love the library, in addition to depending on it, so we would like to support the library in whatever way is most useful.

Is there a particular area where we could contribute?

The people who would we working on this are me, @jbhsieh and @ada-hall

seanpianka commented 2 years ago

Hello all 👋 This would be a very welcome effort by many of the users of this library!

For the highest impact work on this project, check out the 0.13 release's issue. It contains a number of important tasks that are semi-planned to be completed before the next minor version release.

One important notice is that one of our maintainers (@arlyon) has started a fork called async-stripe. It has received a number of major improvements which at present have not been merged back into upstream. In terms of future feature development, starting from this more actively-developed base is something to consider.

Alternatively, if there were three people actively working on upstreaming his changes to this project, that would be a path to benefit the greatest number of users of this crate.

imalsogreg commented 2 years ago

@seanpianka Wonderful! We'll focus on the 0.13 issues, thanks!

@arlyon is the intention that async-stripe would become the focal point for rust's community maintenance efforts on a stripe client? Or is is more like a fork that suited your internal needs, and you would be happy for that work to be backported to stripe-rs here?

arlyon commented 2 years ago

The overall goal is to upstream but we haven't done it yet. @seanpianka and I hopped on to help out in this repo a few months back but aren't core maintainers and since a) I haven't received any acknowledgement or enthusiasm for upstreaming from the core maintainers and b) I don't feel comfortable simply 'replacing' the contents here with my changes, not much has happened.

So, for the time being the intention is to backport but for each day that goes by (and as async-stripe becomes more popular) it looks like its turning into a hard fork.

imalsogreg commented 2 years ago

@arlyon Thanks for the info! I'll both check out async-stripe and make a couple contributions to stripe-rs to try to get the lay of the land. After that, I'd love to help try to break the gridlock.

kushwahashiv commented 2 years ago

@imalsogreg @arlyon I'm also a bit confused which one to use as I'm upgrading stripe-rs but seems this crate is not up to date and lagging dependencies. Now my worry is what if async-stripe have completely different names of enums, structs etc. I hope that's not the case. can you please confirm @arlyon?

thanks /shiv

arlyon commented 2 years ago

The API is the same, there have been minor changes to the client and the error handling to support multiple backends but there have been no changes to the generated API (aside from those caused by stripe itself).

imalsogreg commented 2 years ago

We have new contributors, so I'll close this issue now :) Thanks for the warm welcome! Looking forward to working on this with you.