wyyerd / stripe-rs

Rust API bindings for the Stripe HTTP API.
Apache License 2.0
224 stars 88 forks source link

What is wrong with code review? #75

Closed Yatekii closed 5 years ago

Yatekii commented 5 years ago

The changes from 0.9.2 to 0.10.5 are just questionable ... Now there is a PaymentIntentListParams struct with no constructor or default and all private fields. So this struct is 100% useless. Thus, one cannot do a PaymentIntent::list(). For some types the Default::default() methods were replaced with Self::new() against all convention. I already reported similar stuff where features just were removed out of carelessness or whatever. How does this happen? Sure this is open source and I don't expect a finished product, but this is not nice.

I would have stayed on 0.9.2 but something with the stripe api wont work anymore so I was kinda forced to upgrade to 0.10.5.

I hope this can be addressed quickly and I am also happy to provide a fix.

Best, Yatekii