search

wyze / atom-seti-icons

The awesome icons provided by Seti UI theme.
https://atom.io/packages/seti-icons
MIT License
33 stars 14 forks source link

Explicit font-size:20px breaks themes #13

Closed rondonjon closed 8 years ago

rondonjon commented 8 years ago

I have the Metro UI theme installed (configured to 13px font size) and would like to use seti-icons with it.

Unfortunately the seti-icons package enforces font-size:20px in its stylesheet, which breaks the Metro UI's line heights and selections in the tree view:

lineheight

After temporarily removing the 20px in the developer panel, the seti-icons were smaller, but the other problems were solved.

Any chance to remove this setting officially and/or replacing it with "icon height = line height"?

wyze commented 8 years ago

I tried messing with this a bit tonight. I couldn't come up with a solution.

Once the icons were smaller, they were then misaligned. I think this would be too large of a change that I am not sure how I would approach it. Even if I added a setting to allow you to force all icons to be the same size, it would have the same affect.

In the ui-mixins.less file, each icon can send in their own font-size, and if you look at icons.less, that is exactly what is happening.

screen shot 2015-09-10 at 9 18 43 pm

If you would like to take a stab at it, you're more than welcome to send a PR over.

wyze commented 8 years ago

I just published a new version that came from Seti UI's big 1.0.0 overhaul, so this may have been fixed, but if not I will close due to inactivity.