Icons conflict with git-control after update

wyze / atom-seti-icons

The awesome icons provided by Seti UI theme.

https://atom.io/packages/seti-icons

MIT License

33 stars 14 forks source link

Icons conflict with git-control after update #29

Closed vrouet closed 8 years ago

vrouet commented 8 years ago

Hi,

Since I have updated seti-icons to 1.2.0, I'm having problems with the git-control plugin (https://github.com/jacogr/atom-git-control): some icons just disappear, some others are not the ones they were before.

Here's with seti-icons disabled: screenshot_20160530_130351

And when I enable it: screenshot_20160530_130431

As you can see, the "commit" and the "checked" icons are missing, and the "reset" icon as well as files icons are replaced with weird ones.

vrouet commented 8 years ago

Update: I did some test with all the releases and had to roll all the way back to v0.4.5 for the conflict not to happen. I'm wondering however if this is something I should report to seti-ui or even to git-control

wyze commented 8 years ago

I think if you enable Seti UI along with the plugin (and make sure to disable seti-icons), and there is a conflict with the plugin, then it should be an issue with Seti UI. Otherwise it's an issue with this package.

vrouet commented 8 years ago

I am not using seti-ui. I use dark-ui with seti-syntax. I mentioned seti-ui because it seems you integrate their icons as-is, so I figured the conflict might exist with seti-ui as well.

wyze commented 8 years ago

I tried enabling it with Seti UI, so it seems the problem is there. I'll make an issue and likely send a PR there to fix it and then the fix will flow back into this package.