search

wyze / atom-seti-icons

The awesome icons provided by Seti UI theme.
https://atom.io/packages/seti-icons
MIT License
33 stars 14 forks source link

Please add tab icons #39

Closed victornpb closed 7 years ago

victornpb commented 7 years ago

This is the best icon set, I just miss icons on the tabs.

wyze commented 7 years ago

There are icons on the tabs. Which theme are you using?

UltCombo commented 7 years ago

Confirmed, no tab icons in One Dark UI theme.

UltCombo commented 7 years ago

Oh, the problem is with One Dark's "Tab Sizing" config set to "Minimum" (or "Auto" with a small window).

I've fixed the problem adding this to stylesheet:

[theme-one-dark-ui-tabsizing="minimum"] .tab-bar .tab .title::before {
  position: static;
  margin-top: 0;
  margin-left: 0;
  display: inline-block;
  vertical-align: middle;
}

I believe it is also possible to fix this by just adding a padding-left value to the .tab title, but seeing as the icons' width are not always the same, it seems hacky to do so and very hard to find a value that looks properly centered with the various icons (i.e. visually the same padding in the left and right sides of the tab title).

wyze commented 7 years ago

Hi @UltCombo, thanks for digging into this. Would you want to send that over in a PR?

UltCombo commented 7 years ago

Sure. I've also added support for [theme-one-dark-ui-tabsizing="auto"] with a small window as well as the One Light equivalents: #51

wyze commented 7 years ago

Thanks for the fix, I'll get this in the next release.