search

wyze / bs-react-testing-library

BuckleScript bindings for react-testing-library.
https://yarn.pm/bs-react-testing-library
MIT License
36 stars 15 forks source link

Run bisect conditionally #20

Closed wyze closed 4 years ago

wyze commented 4 years ago

Close #19

jihchi commented 4 years ago

Hi @wyze ,

Sorry to hijack this merged PR. I am not sure if you are aware of this, just wanted to for your information:

bisect_ppx has to be a regular dep; see aantron/bisect_ppx#309 (comment). This is because the ppx-flags in bsconfig.json cause Bisect to always be called. It's just when BISECT_ENABLE=yes is missing, Bisect leaves the code clean and uninstrumented. But the code still gets passed through Bisect.

Once BuckleScript releases dev ppx-flags (BuckleScript/bucklescript#3761) in the next release, it will be correct to move bisect_ppx to devDependencies, which is where it properly belongs :)

wyze commented 4 years ago

@jihchi Yup I saw it. I am waiting for the dev-ppx-flags as well. I have a small package that runs on CI only that updates the bsconfig.json and adds the ppx-flags and bisect_ppx to bs-dependencies. So far working good!