search

wz-chan / pe

0 stars 0 forks source link

UI does not update after using valid "deletepsngrp" command #4

Open wz-chan opened 3 years ago

wz-chan commented 3 years ago

Person in index 1 and 2 are in the FITNESS group. After using the "deletepsngrp g/FITNESS" command, person 1 and 2 are still shown as part of FITNESS. You need to click on any part of the list once for the data to be updated.

image.png

Perhaps the list should be updated automatically.

nus-pe-bot commented 3 years ago

Team's Response

This issue is a duplicate

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

deletepsngrp not working

Function Description

Deletes every person from that group in the addressbook.

Scenario

I wanted to delete everyone from group TESTING1.

image.png

executed deletepsngrp g/TESTING1

expected scenario.

Bernice Yu and James Lee to be deleted.

Actual Scenario.

image.png

[original: nus-tic4002-AY2021S2/pe-interim#42] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Tester error.

All person assigned is deleted from the group. however this issue is about the function failing to work. This is an invalid issue.

You may check that the deletion has been completed successfully by using "listfromgrp" command. As the function does not automatically refreshes the UI.

You still see the group name under the contact as the UI did not automatically refresh. This is to allow user to see who are previously assigned to that group even if the delete operation is performed. Should they no longer require the view they can perform a manual refresh. This is taking usability into perspective.

However, using the "listfromgrp" command will allow you to manually refresh the UI and you can see the deletion being effected.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: My concern is different from the other tester even though it is the same bug. The other tester seemed to think that the "deletepsngrp" feature is not working. For my case, I was referring to the problem with the data not being automatically updated in the UI.

I've tried the "deletepsngrp" command a few times. In certain situations, the UI automatically refreshes and in some other situations, it does not. If the "deletepsngrp" is used as the first command when you start the app, the UI always refreshes automatically. Only after certain operations would the auto refresh fail.

If this is indeed a usability feature like what your group has mentioned, then it should consistently not refresh. Moreover, there is no mention of this manual refresh mechanism, in the UG, that is required after using this command .

:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]