Closed josephsumabat closed 7 months ago
seems reasonable, though I wish we had the full Module
including the Unit
instead of just a ModuleName
.
seems reasonable, though I wish we had the full Module including the Unit instead of just a ModuleName.
I think that might require adding the information to the hie file upstream? Might be a trivial way of getting it that I'm missing though.
well this information is in the modiface (.hi) file, and the idea to not include it in the .hie
file was that consumers could get it from there. Perhaps this was not the best idea, or perhaps we should just index .hi
files if we want this info to be accurate.
Hm it would be unfortunate to have this rely on the modiface files as well. One of the really nice things about hiedb
is how there's only a single target (the directory with .hie
files). I do think it's still useful even without unit but I defer to you on whether this belongs as a part of hiedb (lmk if you want me to close the PR/feel free to close it if you don't think it belongs/ or want me to modify it to use interface files instead).
Would love to get your thoughts on this/upstream this if you think it's useful @wz1000
Some features/utility that this would enable:
In theory this could be done by traversing the module's imports on the fly but it's nice to have access to that information via the tables.
This also does not demonstrably increase the indexing time either on a codebase the size of mwb from my testing