wz1000 / HieDb

Generates a references DB from .hie files
BSD 3-Clause "New" or "Revised" License
64 stars 24 forks source link

Remove CPP for no longer supported GHC <9.0 #70

Closed jhrcek closed 8 months ago

jhrcek commented 8 months ago

The package no longer builds with GHCs older than 9.0.

When you try cabal build with ghc 8.10.7, you get this error:

Failed to build hie-compat-0.3.1.2.
Build log (
/home/jhrcek/.cabal/logs/ghc-8.10.7/hie-compat-0.3.1.2-6cd25c57f80a4565be3fe6faa473ae59b8a96c9dd34aa406aef36d991f3ccd54.log
):
Configuring library for hie-compat-0.3.1.2..
Preprocessing library for hie-compat-0.3.1.2..
Error: cabal-3.10.2.1: can't find source for Compat/HieAst in .,
dist/build/autogen, dist/build/global-autogen

Error: cabal: Failed to build hie-compat-0.3.1.2 (which is required by
test:hiedb-tests from hiedb-0.6.0.0). See the build log above for details.

Support for ghc 8.10 and older was removed from hie-compat in https://github.com/haskell/haskell-language-server/pull/3434

So I'd say that we can safely remove CPP related to older GHCs from this repo too AND mention it in the changelog.