search

wz2b / node-red-contrib-influxdb-line-protocol

Parses InfluxDB Line Protocol to JSON and vice versa.
MIT License
1 stars 2 forks source link

Questions about this module #1

Closed wz2b closed 2 years ago

wz2b commented 2 years ago
  1. Do you have instructions on how to install this manually, as it doesn't seem to be in npm?
  2. Do you have any interest in adding it to npm?
  3. If you don't, do you mind if I fork it and contribute it to npm?
  4. I think it would be simpler to make separate nodes for "line to json" and "json to line." Doing what you did (where it dynamically transforms it from one to another) is clever but I think I'd rather be more explicit, and have it generate an error if the input message was in an unexpected format. Would you be OK with this, and would you prefer I add or replace?

I'm looking for a few more options for creating line protocol messages. The main addition I'm looking for is the ability to specify a static tag set in the node configuration. I could do this by adding another node or by modifying one of the existing nodes. My use case involves writing these messages to MQTT to be picked up by a telegraf instance somewhere else, which is what actually gets them to influxdb. Telegraf can them route the message elsewhere if configured to do so. So the basic, generic object model of "measurement tagset fieldset" makes sense even if the ultimate destination is sql, aws iot, prometheus, etc. Because of that I'm interested in developing this module a little further.

Really, I'm going to go ahead with this on my own. The main issue is I don't want to step on you by publishing this under the same name if you intended to do this yourself. It looks like you haven't worked on this in a few years, if you've lost interest, I'll just take it over.

opatut commented 2 years ago

Hello, sorry I didn't notice this post earlier, it got buried in github notificatinos.

To be honest, I totally forgot that I ever wrote this thing. It appears I did from the commit history, but I just can't recall. I know I used to play around with this, so it makes sense ;)

I would be happy if you took over. Do with it what you want, it's MIT licensed after all. Thanks for asking, though.

If you want, I can transfer the repo to you, Github would even create a redirect from this URL, and you could do all of the above. Take the name, take the code, append your name to the license file if you want (just keep mine there too) and we're good!

wz2b commented 2 years ago

OK sure, we can transfer it if you want. I'll leave your node as-is and just add two more. The one you made will be the 'automatic' one and I'll also make some 'explicit' to and from nodes that have an optional error output. This way i won't break anybody already using your stuff.

My github is wz2b if you want to try to transfer it, do I have to do anything?

On Thu, Mar 3, 2022 at 9:31 AM Paul Bienkowski @.***> wrote:

Hello, sorry I didn't notice this post earlier, it got buried in github notificatinos.

To be honest, I totally forgot that I ever wrote this thing. It appears I did from the commit history, but I just can't recall. I know I used to play around with this, so it makes sense ;)

I would be happy if you took over. Do with it what you want, it's MIT licensed after all. Thanks for asking, though.

If you want, I can transfer the repo to you, Github would even create a redirect from this URL, and you could do all of the above. Take the name, take the code, append your name to the license file if you want (just keep mine there too) and we're good!

— Reply to this email directly, view it on GitHub https://github.com/opatut/node-red-contrib-influxdb-line-protocol/issues/1#issuecomment-1058099556, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTMONK5FWKZMM35H3NANTU6DELVANCNFSM5M6LCEDQ . You are receiving this because you authored the thread.Message ID: @.*** .com>

opatut commented 2 years ago

You need to delete or rename your fork, then I can transfer the repo (it won't be renamed so you need to have that URL free). Then I start the transfer and you need to accept it, I assume you get an email.

wz2b commented 2 years ago

Sorry for the delay! This just became hot though.

You need to delete or rename your fork, then I can transfer the repo (it won't be renamed so you need to have that URL free).

Done!

On Thu, Mar 3, 2022 at 2:57 PM Paul Bienkowski @.***> wrote:

You need to delete or rename your fork, then I can transfer the repo (it won't be renamed so you need to have that URL free). Then I start the transfer and you need to accept it, I assume you get an email.

— Reply to this email directly, view it on GitHub https://github.com/opatut/node-red-contrib-influxdb-line-protocol/issues/1#issuecomment-1058430312, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTMOM7R54HHPMEXWQ6UXTU6EKTVANCNFSM5M6LCEDQ . You are receiving this because you authored the thread.Message ID: @.*** .com>

opatut commented 2 years ago

Cheers! :tada:

wz2b commented 2 years ago

Wow that was fast!

On Thu, Mar 24, 2022 at 8:22 AM Paul Bienkowski @.***> wrote:

Closed #1 https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1 .

— Reply to this email directly, view it on GitHub https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1#event-6299038939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTMOI6HVLF5MDDWNHGFHTVBRM7ZANCNFSM5M6LCEDQ . You are receiving this because you authored the thread.Message ID: <wz2b/node-red-contrib-influxdb-line-protocol/issue/1/issue_event/6299038939 @github.com>

wz2b commented 2 years ago

Paul, did you ever put this into npm? If you did I'll have to be named a contributor to publish.

On Thu, Mar 24, 2022 at 8:24 AM Christopher Piggott @.***> wrote:

Wow that was fast!

On Thu, Mar 24, 2022 at 8:22 AM Paul Bienkowski @.***> wrote:

Closed #1 https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1 .

— Reply to this email directly, view it on GitHub https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1#event-6299038939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTMOI6HVLF5MDDWNHGFHTVBRM7ZANCNFSM5M6LCEDQ . You are receiving this because you authored the thread.Message ID: <wz2b/node-red-contrib-influxdb-line-protocol/issue/1/issue_event/6299038939 @github.com>

wz2b commented 2 years ago

disregard, it wasn't in npm. I submitted it to npm and also to the node red catalog, won't be bothering you now :-)

On Thu, Mar 24, 2022 at 3:39 PM Christopher Piggott @.***> wrote:

Paul, did you ever put this into npm? If you did I'll have to be named a contributor to publish.

On Thu, Mar 24, 2022 at 8:24 AM Christopher Piggott @.***> wrote:

Wow that was fast!

On Thu, Mar 24, 2022 at 8:22 AM Paul Bienkowski @.***> wrote:

Closed #1 https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1 .

— Reply to this email directly, view it on GitHub https://github.com/wz2b/node-red-contrib-influxdb-line-protocol/issues/1#event-6299038939, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALTMOI6HVLF5MDDWNHGFHTVBRM7ZANCNFSM5M6LCEDQ . You are receiving this because you authored the thread.Message ID: <wz2b/node-red-contrib-influxdb-line-protocol/issue/1/issue_event/6299038939 @github.com>