[RSN-34] - Create navbar and footer

rogacky11 commented 5 months ago

Description

I have added visual changes to our web application using tailwind css.

Motivation

This change is needed to create navbar and footer.

Related issue and/or ticket

RSN-34

wzarek commented 4 months ago

@rogacky11 why there is a link to RSN-14?

if it's ready for review why isn't it marked as ready for review?

rogacky11 commented 4 months ago

@rogacky11 why there is a link to RSN-14?
* if it's ready for review why isn't it marked as ready for review?

I apologize for my mistake, link changed. I also forgot about ready for review status, so it has been immediately added.

wzarek commented 4 months ago

@rogacky11 why there is a link to RSN-14?
* if it's ready for review why isn't it marked as ready for review?
I apologize for my mistake, link changed. I also forgot about ready for review status, so it has been immediately added.

Do it via youtrack, just drag the issue in in review state and it will assign the status automatically here

rogacky11 commented 4 months ago

Also - better idea would be to put the links - Reasn, logowanie, rejestracja inside another div like below:

Instead of making some weird margins mx-60 you can specify it's with in % (3/4 would be 75% as in design). One more thing - you didn't format it properly from what I see, so it will be needed to use some sort of prettier or something for that. Also, you can name it not Nav.tsx but something more meaningful like Navbar or Menu or something like that and place it in 'components' folder. Also - making separate components for Links like logowanie and rejestracja could be a good idea, since it will be reusable then and we (for logged user) want to display more than that, so it shouldnt be hardcoded. + if Link type is not used, it should be deleted (also styles import).

And the last thing - where is the footer?

I took your advices into account and added adequately. But still using eg. w-3/4 I think I have to use margin. Am i right? And the last thinkg - footer has been added.

wzarek commented 4 months ago

@rogacky11 if it's ready for review mark it as ready for review, currently it's a draft PR

wzarek commented 4 months ago

@rogacky11 please resolve conflicts / rebase + format code

wzarek commented 4 months ago

Created #47

wzarek / Reasn