Changed double quote to single quote replacement with logic that changes

x-atlas-consortia / data-ingest-board

The UI App for HuBMAP and Sennet Data Publishing Dashboard

MIT License

0 stars 0 forks source link

Changed double quote to single quote replacement with logic that changes #135

Closed DerekFurstPitt closed 8 months ago

DerekFurstPitt commented 8 months ago

Small tweak to change where double quotes in an object were replaced with single quotes. Now a double quote is instead replaced with 2 double quotes to escape them. To go with this, the outer wrapping double quotes are removed. This seems to make csv's behave properly across excel, libre office spreadsheet etc.

yuanzhou commented 8 months ago

@libpitt thanks for the review. We should be good with Derek's tweaks. I understand your comment on the [] format, it doesn't really matter in the CSV, we just need to display multiple {} items without the outer []. The CSV consumers will need to parse that according their needs.

libpitt commented 8 months ago

@yuanzhou Great, sounds good. And I guess we are not concerned with ingest_task for now?