Libpitt/22 derivedd - Githubissues

x-atlas-consortia / data-ingest-board

The UI App for HuBMAP and Sennet Data Publishing Dashboard

MIT License

1 stars 0 forks source link

Libpitt/22 derivedd #162

Closed libpitt closed 9 months ago

libpitt commented 9 months ago

Change log:

DRY modifiedData logic to helper TABLE.flattenDataForCSV .
Use rawData instead to correctly allow for building of table of descendant_datasets
Create ModalOverData component
Move status column object to helper in TABLE.reusableColumns for easy reuse in ModalOverData
Remove UTC string

Requires: https://github.com/sennetconsortium/ingest-api/pull/285 https://github.com/hubmapconsortium/ingest-api/pull/482

maxsibilla commented 9 months ago

@libpitt It doesn't seem like the new Has Derived Datasets column sorts correctly

yuanzhou commented 9 months ago

@libpitt @maxsibilla When Bill and I discussed about this feature, clicking one of the derived datasets in the modal would also show all the external links instead of just one link.

In addition, do you mind also making the following tweaks?

Add the count of the derived datasets to the modal title
Change the column name to just "Derived Datasets" and show the number of counts only for the ones without any and the ones with more than 1 derived datasets. Saying "HBM322.ZKRX.545 ...(2)" can be misleading and may imply there are 2 additional datasets in addition to "HBM322.ZKRX.545". It's fine to just show the ID when there's only one.

libpitt commented 9 months ago

@yuanzhou Made those changes. Let me know if you need anything else updated.