search

x-atlas-consortia / data-ingest-board

The UI App for HuBMAP and Sennet Data Publishing Dashboard
MIT License
0 stars 0 forks source link

Libpitt/166 version col #170

Closed libpitt closed 6 months ago

libpitt commented 6 months ago

Change log:

  1. Add Revisions column (lazy loads revision data to avoid querying more than necessary in /datasets/data-status)
  2. Add button to download CSV of data of derived/processed Datasets
  3. Remove descendant_datasets from main CSV
  4. Add entity api env config

Requires: https://github.com/sennetconsortium/ingest-api/pull/301 https://github.com/hubmapconsortium/ingest-api/pull/502

yuanzhou commented 6 months ago

@bhonick I wanted to confirm with you that you are not using the descendant_datasets from the CSV download, are you?

image

bhonick commented 6 months ago

@yuanzhou I'm aware of it but am not actively using it for anything.

yuanzhou commented 6 months ago

@yuanzhou I'm aware of it but am not actively using it for anything.

Great! We are removing this column since it may contain a long list of descendants and won't be much help for actual use. We are also adding another CSV download of all the processed datasets which can be more desired.

libpitt commented 6 months ago

@yuanzhou All changes can be made except the time one. I am not controlling the format of the timestamp in the ui table, that's using date.toLocaleString(). If I use that for CSV, then another user elsewhere would have different format if they have a different locale.

As for the one in the CSV, the format of the string determined by date.toUTCString().

So if you're okay with another user elsewhere having a different format when downloading the CSV, I can also use the same toLocaleString() method.