search

x-atlas-consortia / data-ingest-board

The UI App for HuBMAP and Sennet Data Publishing Dashboard
MIT License
0 stars 0 forks source link

Check that method exists #181

Closed libpitt closed 6 months ago

libpitt commented 6 months ago

Change log:

  1. Check that method exists
yuanzhou commented 6 months ago

FYI @libpitt @maxsibilla, because the current dev-integrate branch contains the bulk-select stuff, and HuBMAP doesn't have the backend support yet. If this fix solves the issue, we can merge into main and do a quick release and then sync into dev-integrate. So it addresses the issue for Gesina and also doesn't affect the bulk-select feature that SenNet is testing while HuBMAP not.

maxsibilla commented 6 months ago

@yuanzhou This branch can be merged into dev-integrate first and tested to confirm. The fix is simple and doesn't require any of the new back-end changes

yuanzhou commented 6 months ago

@yuanzhou This branch can be merged into dev-integrate first and tested to confirm. The fix is simple and doesn't require any of the new back-end changes

The current HuBMAP DEV deploy still uses the version prior to when you merged the bulk-select via PR https://github.com/x-atlas-consortia/data-ingest-board/pull/177. If we redeploy dev-integrate on HuBMAP DEV, would it show the bulk-select feature? I'm concerned it'll break since HuBMAP doesn't have the backend support yet. I'm not concerned about this new fix since it's based off main which doesn't have the bulk-select feature.