Closed shirey closed 4 weeks ago
Alert, @shirey @jpuerto-psc we can't merge this PR into main
. jpuerto/rules-engine-integration
branch was created off dev-integrate
and will pollute the commit history of main
.
Thanks @yuanzhou - I think we were planning on just deleting this branch since these changes carried in to #147.
I think that we overcomplicated things.
At this point, I think that we can resolve this by just manually copying the ontologies.json over to the hs-ontology-api dev branch.
We might want to consider moving the "dev server" thingy into its own repo.
I agree with @AlanSimmons. Any future changes to the dev/assayclasses.json
should be branched off the latest main
then PR into dev-integrate
rather than using dev-integrate
as the base branch. This will prevent us from messing up the commit history of main
.
Another option would be to move the files in the dev folder path into a separate repo, with the understanding that any PRs would merge only with dev-integrate. That would keep the static dev server separate from the hs-ontology-api. The dev server shares no files with hs-ontology-api, so it really shouldn't be in this repo, anyway.
@AlanSimmons - feel free to discuss this w/ @shirey I have no opinion on where the code for this should live. Just need a server to hit against for testing
Add Segmentation Masks, GeoMx, RNAseq (with probes) and Xenium assay types to interim/dev assayclasses.json file.