Closed Digi-Cazter closed 5 years ago
Thanks for the contribution!
I'll need to work on a better way to run the tests, as this change requires further configuration on the Event Store side to pass. I think the easiest approach will be to run the tests in Docker containers, so that we can spin up an Event Store instance with the secure TCP port enabled and a suitable TLS certificate installed.
Just to update you, I've pushed a change to the master branch that uses a Docker container to run the tests. We can leverage that for testing the TLS functionality by configuring the Event Store Docker container to start up TLS support on port 1114 and generate a suitable self-signed certificate for it to use.
Feel free to look into hooking this up yourself, otherwise I'll get round to it when I get the chance.
Is this going to be merged?
See my comments above. It needs unit tests before I'm happy to merge it.
@Digi-Cazter do you think you'll have time to do this?
I've added the ability to connect using TLS
I've also added tests as well and made sure they passed before creating this.