search

x-cubed / event-store-client

JS client library for connecting to Event Store over TCP/IP
The Unlicense
71 stars 24 forks source link

typedefinition bug #38

Closed ghost closed 5 years ago

ghost commented 5 years ago

In the type definition: subscribeToStreamFrom(streamId: string, fromEventNumber: number, ...)

Should be: subscribeToStreamFrom(streamId: string, fromEventNumber: number | null, ...)

It is missing the | null, for the fromEventNumber parameter. Without it, you cannot read from the beginning of the stream.

x-cubed commented 5 years ago

Thanks for pointing that out, I've pushed a commit to resolve it