search

x-govuk / govuk-components

Lightweight Ruby on Rails components for developing with the GOV.UK Design System.
https://govuk-components.netlify.app
MIT License
150 stars 20 forks source link

Add custom tag to notification banner heading #533

Closed DavidBiddle closed 6 months ago

DavidBiddle commented 6 months ago

Adds an optional tag to the notification banner component's heading, so that the user can easily customise the heading. This makes it easier for users to create notification banners with the correct heading heirarchy.

Closes #531.

netlify[bot] commented 6 months ago

Deploy request for govuk-components pending review.

Visit the deploys page to approve it

Name Link
Latest commit 43efbcd5d3b473929c1a3308740fc422c73ce9fe
peteryates commented 6 months ago

Sorry left a comment before realising it was still in draft! Looking spot on though 👌🏽

DavidBiddle commented 6 months ago

Thanks @frankieroberto - I don't have permissions to merge on this repo, is that something you're able to do?

frankieroberto commented 6 months ago

Thanks @frankieroberto - I don't have permissions to merge on this repo, is that something you're able to do?

I can, but I’ll let @peteryates do a quick final check too.

DavidBiddle commented 6 months ago

Thank you both for your help on this!