x-govuk / govuk-design-history-template

Document and share design decisions. Create a permanent record of how your service has developed over time.
MIT License
23 stars 9 forks source link

All actions now break which makes it hard to debug remote repositories #304

Closed vickytnz closed 2 weeks ago

vickytnz commented 2 weeks ago

The new github actions mean that when I copy the template the workflows all break. I though that this might be because I did a private repo without Github pages, but when I tried a repo which was public and had pages it still didn't work.

Examples of actions breaking here: https://github.com/vickytnz/xgov-design-history/actions

I don't really want this working on Github pages as i'd rather have it on a password protected heroku, but the breaking tests seem to mean I can work locally but not remotely.

Ideally there would be a way to turn off this workflow until it's set up on github pages (or not at all), and have it as a toggle.

frankieroberto commented 2 weeks ago

@vickytnz ah, thanks for reporting! I wonder if there's a way to have the GitHub actions on the repo but not included as part of the "template"... I'll investigate! Although the workflow is useful for people who do want to deploy to GitHub pages, so maybe it should be an option. Hmm.

In the meantime you can turn the action off by deleting .github/workflows/deploy.yml.

Why the build on your repo is failing is another puzzle...

frankieroberto commented 2 weeks ago

@vickytnz Ah, so it looks like there are 2 separate issues:

I think if you were to change this setting from 'Deploy from a branch (GitHub Classic)' to 'GitHub Actions' then it might all work?

Screenshot 2024-07-09 at 22 35 36

(and yes this is all needlessly fiddly... We'll have to try and improve the documentation on this to get people through these initial hurdles!)