Change hint element to div instead of span tag

x-govuk / govuk-form-builder

A form builder for Ruby on Rails that’s compatible with the GOV.UK Design System.

https://govuk-form-builder.netlify.app

MIT License

75 stars 21 forks source link

Change hint element to div instead of span tag #338

Closed ivanELEC closed 2 years ago

ivanELEC commented 2 years ago

The 4.0.0 update to govuk-frontend has removed styling that made span elements display as block for the hint element for semantic reasons. In VCD the only usage of the hint class is via the form builder which it seems assigns span to the element in this file on line 46

The value of this is explained in this stack overflow post, as span elements are semantically reserved for inline elements

peteryates commented 2 years ago

Yeah - there's a 3.0.0 branch that implements the changes made by v4 of the design system here and a beta release that includes the changes.