Remove primary navigation component

x-govuk / govuk-prototype-components

Use common components that are not yet part of the GOV.UK Design System.

MIT License

3 stars 2 forks source link

Closed paulrobertlloyd closed 1 month ago

paulrobertlloyd commented 2 months ago

Remove primary navigation component
Remove documentation for primary navigation component, but keep page with a link to Service navigation on GOV.UK Design System website
Remove examples for the primary navigation component
Update remaining documentation and examples to use Service navigation component, where relevant
Bump package to v4.0.0, a breaking MAJOR release

frankieroberto commented 2 months ago

paulrobertlloyd commented 2 months ago

Why do you spoil all my fun @frankieroberto 🥹

So maybe we do a MINOR release, and add deprecation notices where we can. Am thinking:

On the docs, add the above banner
In SCSS, output deprecation warning to the console
In the Prototype Kit templates, includes a deprecation message in the meta data somewhere
Possibly in the Nunjucks somehow, include a filter that outputs a deprecation message to the console

Then, in version 4, remove the component as shown in this PR. I might try and achieve the above in a separate PR.

frankieroberto commented 2 months ago

@paulrobertlloyd that sounds reasonable to me!

We could also do a bit of proactive outreach to the repos who’re using the component to warn them about the deprecation.