Closed ohbarye closed 1 year ago
This change got unnecessary for me, so I'm closing.
@ohbarye I believe this feature is exactly what my team needs. Would it be possible for you to reopen this pull request, or would you prefer that I take over the work?
@masaru-iritani Sure. Please go ahead as you like!
@onk @motemen
Issue
Closes #54
Changes
As described in https://github.com/x-motemen/git-pr-release/issues/54, I added
aggregate_labels
feature.pr-release.aggregate_labels
config (orGIT_RELEASE_PR_AGGREGATE_LABELS
)."true"
or anything"true"
,git-release-pr
aggregates labels from merged pull requests.pr-release.labels
is given at the same time?pr-release.labels
setting.pr-release.labels=foo,bar
and aggregated labels arebaz
, then labels would be["foo", "bar", "baz"]
.Testing
That worked well on my own
Review Points
aggregate_labels
an appropriate name?reuse_labels
,summarize_labels
... etc.aggregate_labels
be given as a command line arg, not environment variable or git config?--dry-run
,--no-fecth
,aggregate_labels
is boolean-ish value. So I wonder if it should be. (It depends on this gem's command line design.)