search

x-motemen / git-pr-release

Release pull request generator
https://rubygems.org/gems/git-pr-release
MIT License
684 stars 74 forks source link

Remove exit statuses that are never returned #57

Closed ohbarye closed 2 years ago

ohbarye commented 3 years ago

Change

The README describes exit status 2, 3, 4 for each error. But the code to return those statuses have disappeared at https://github.com/x-motemen/git-pr-release/commit/7afcbc47b0ffc36f4cdd69537b7e911948b8e191 and they are never returned since v1.2.0.

Therefore, I'd say the description on README is obsolete and should be updated.

Songmu commented 2 years ago

Yes, we can remove it. Thanks.

Currently, when a request fails, an exception is raised, a stack trace is displayed, and the error ends. As a future enhancement, it would be better to handle them and check the response status to make the error easier to understand.

ohbarye commented 2 years ago

thanks!