Open masaru-iritani opened 8 months ago
@onk Thank you for taking a look into this! I'd like to know if there are any outstanding concerns or areas for improvement necessary for moving this forward. Your feedback would be greatly appreciated. Looking forward to your response!
@onk @motemen
This is a revival of #56 originally done by @ohbarye, who kindly allowed me to take over the work. The only change I made is changing the config name from
aggregate_labels
toaggregate-labels
becausegit config
returns an error when the config name contains underscores.Issue
Closes #54
Changes
As described in #54, this change adds a feature to add labels assigned to merged pull requests.
pr-release.aggregate-labels
config (orGIT_RELEASE_PR_AGGREGATE_LABELS
environment variable). It accepts a boolean-ish value, "true" or anything. Only when it is "true",git-release-pr
aggregates labels from merged pull requests.pr-release.labels
is given at the same time, merge them. For example, whenpr-release.labels=foo,bar
and aggregated labels are "baz", labels would be ["foo", "bar", "baz"].Testing
Confirmed
git-pr-release
with this change created a release pull request with a label assigned to a merged pull request.Review Points
aggregate-labels
the best name among other ideas such asreuse-labels
andsummarize-labels
, etc.?aggregate-labels
be given as a command line argument, not environment variable orgit config
, like other boolean values such as--dry-run
and--no-fecth
? (It depends on this gem's command line design.)