search

x-tag / core

The Heart of X-Tag
http://x-tag.github.io/
Other
1.25k stars 151 forks source link

Fix integration with `WebReflection/document-register-element` polyfill #154

Closed ramybenaroya closed 8 years ago

ramybenaroya commented 8 years ago

fix for https://github.com/x-tag/core/issues/153

csuwildcat commented 8 years ago

Thank you for highlighting this, I didn't realize some polyfills/libraries were turning logic based on key presence. Can you check out what I just threw up on master: https://github.com/x-tag/core/blob/master/src/core.js#L411-L418

csuwildcat commented 8 years ago

I haven't pushed that out yet to NPM/Bower, so let me know if it works against your test cases. (it passes all of our tests)

ramybenaroya commented 8 years ago

Works great.

ramybenaroya commented 8 years ago

Fixed https://github.com/x-tag/core/commit/619d2b0b940b1439283b6d52002fddf63c7d5d7e