Uncaught illegal access error on Android stock browser (chromium ~34)

x-tag / core

The Heart of X-Tag

http://x-tag.github.io/

Other

1.25k stars 151 forks source link

Uncaught illegal access error on Android stock browser (chromium ~34) #160

Closed ramybenaroya closed 8 years ago

ramybenaroya commented 8 years ago

Can be reproduced with LG3/4 with Android 5.0 The problem is in core.js:37 In this version of Chromium, an object of type CSSStyleDeclaration cannot be sliced. As a result the entire core.js script is not evaluated at all.

csuwildcat commented 8 years ago

@ramybenaroya is this Chrome or the stock browser on the LG 3/4? I ask because my wife's Galaxy S6 with 5.0+ and Chrome 34+ does not throw this error in either Chrome or the stock browser.

ramybenaroya commented 8 years ago

@csuwildcat Stock browser (not chrome)

User Agent:

Mozilla/5.0 (Linux; U; Android 5.0; en-us; LG-D855 Build/LRX21R.A1445306351) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/34.0.1847.118 Mobile Safari/537.36

LG3 Phone Software Info

Console when loading x-tag gh-page

csuwildcat commented 8 years ago

@ramybenaroya I was able to avoid messing with computed styles altogether - can you checkout the latest on master and test against that Android browser env? It is passing all of our tests.

ramybenaroya commented 8 years ago

@csuwildcat All green 👍

csuwildcat commented 8 years ago

Thank you for the report!