search

x-tag / core

The Heart of X-Tag
http://x-tag.github.io/
Other
1.25k stars 151 forks source link

xtag.prefix detecting "webkit" for Internet Explorer 10 and 11 #164

Open jpecor-pmi opened 7 years ago

jpecor-pmi commented 7 years ago

xtag.prefix is returning {dom: "webkit", lowercase: "webkit", css: "-webkit-", js: "Webkit"} for Internet Explorer 10 and 11. This causes matchSelector to be undefined in these browsers, because it tries to assign it the value of Element.prototype['webkitMatchesSelector'] instead of Element.prototype['msMatchesSelector'].

csuwildcat commented 7 years ago

Hmm, it should be finding the MS prefix first - I will investigate. Edge supports the Webkit properties for compat sake, so that's probably why it is assigning it.

mnkami commented 7 years ago

Are there any updates? Is there any chance to make a quick fix like this: https://github.com/mnkami/core/commit/e63434d0871bdc49a1442c3d69be77a1ef41e1cd

csuwildcat commented 7 years ago

Yes, we can just make that check explicit

On Jan 26, 2017 2:26 AM, "Mykyta Mazurenko" notifications@github.com wrote:

Are there any updates? Is there any chance to make a quick fix like this: mnkami@e63434d https://github.com/mnkami/core/commit/e63434d0871bdc49a1442c3d69be77a1ef41e1cd

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/x-tag/core/issues/164#issuecomment-275355348, or mute the thread https://github.com/notifications/unsubscribe-auth/AAICysGizG79gyrg0PgPBej3kBqpcxbXks5rWHTvgaJpZM4Kgf_V .